Re: [PATCH 1/5] leds: core: Drivers shouldn't enforce SYNC/ASYNC brightness setting

From: Jacek Anaszewski
Date: Fri Oct 09 2015 - 04:08:27 EST


On 10/09/2015 09:02 AM, Pavel Machek wrote:
On Fri 2015-10-09 08:28:44, Jacek Anaszewski wrote:
On 10/08/2015 05:50 PM, Pavel Machek wrote:
On Mon 2015-09-21 16:29:26, Jacek Anaszewski wrote:
This patch removes SET_BRIGHTNESS_ASYNC and SET_BRIGHTNESS flags.

s/SET_BRIGHTNESS/SET_BRIGHTNESS_SYNC/

led_set_brightness now calls led_set_brightness_nosleep instead of
choosing between sync and async op basing on the flags defined by the
driver.

Are those flags unused in the version of kernel you are patching?

The flags are used until this patch.

Hmm. I seen you removing the definitions, but not removing any
users. I guess I missed something.

Only LED core is the user. It sets SET_BRIGHTNESS_SYNC flag
for LED flash class drivers.

--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/