Re: [PATCH tip/core/rcu 02/18] rcu: Move rcu_report_exp_rnp() to allow consolidation
From: Peter Zijlstra
Date: Fri Oct 09 2015 - 04:45:14 EST
On Thu, Oct 08, 2015 at 05:10:21PM -0700, Paul E. McKenney wrote:
> > Note that there are rnp->lock acquires without the extra barrier though,
> > so you seem somewhat inconsistent with your own rule.
> >
> > See for example:
> >
> > rcu_dump_cpu_stacks()
> > print_other_cpu_stall()
> > print_cpu_stall()
> >
> > (did not do an exhaustive scan, there might be more)
> >
> > and yes, that is 'obvious' debug code and not critical to the correct
> > behaviour of the code, but it is a deviation from 'the rule'.
>
> How about the following patch on top of yours?
Works for me, Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/