Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

From: Mark Brown
Date: Fri Oct 09 2015 - 07:38:39 EST


On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:

> What is the point of doing this void cast below?
> Avoiding compiler warning perhaps?
> Perhaps you can __maybe_unused for the variable instead?

> > + /* Ignore message */
> > + (void)msg;

You shouldn't need it at all, but yes if there is a good reason to mark
something as unused the above annotation is better.

Attachment: signature.asc
Description: Digital signature