Re: [PATCH 2/2] smack: smk_ipv6_port_list should be static

From: Casey Schaufler
Date: Fri Oct 09 2015 - 18:19:25 EST


On 9/27/2015 8:10 AM, Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/smack/smack_lsm.c:55:1: warning: symbol 'smk_ipv6_port_list'
> was not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@xxxxxxx>

Acked-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx>
Applied to https://github.com/cschaufler/smack-next.git#smack-for-4.4

> ---
> security/smack/smack_lsm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 996c889..f02438c 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -52,7 +52,7 @@
> #define SMK_SENDING 2
>
> #ifdef SMACK_IPV6_PORT_LABELING
> -LIST_HEAD(smk_ipv6_port_list);
> +static LIST_HEAD(smk_ipv6_port_list);
> #endif
> static struct kmem_cache *smack_inode_cache;
> int smack_enabled;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/