Re: [PATCH 14/14] cgroup: add cgroup_subsys->free() method and use it to fix pids controller

[Tejun Heo]

Hello,

On Mon, Oct 12, 2015 at 09:29:14PM +1100, Aleksa Sarai wrote:
> > pids controller is completely broken in that it uncharges when a task
> > exits allowing zombies to escape resource control.  With the recent
> > updates, cgroup core now maintains cgroup association till task free
> > and pids controller can be fixed by uncharging on free instead of
> > exit.
> 
> Looks good to me. Out of interest, is there any reason why we still
> have ->exit(), given the zombie process edge case? Surely the zombie
> process edge case would cause issues with kmemcg and similar
> controllers, if they use ->exit() and not ->free()?

No, pids was the only broken one.  ->exit() is no longer used but
let's see how it goes for a while before getting rid of it.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/