Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap

From: Mark Brown
Date: Mon Oct 12 2015 - 12:27:38 EST


On Mon, Oct 12, 2015 at 12:48:58PM +0200, Markus Pargmann wrote:
> On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote:

> > + /* if set, only the cache is modified not the HW */
> > + bool cache_only;
> > + /* if set, only the HW is modified not the cache */
> > + bool cache_bypass;
> > + /* if set, the cache contains newer data than the HW */
> > + bool cache_dirty;

> Why are these last three variables just moved and not changed to u8 of
> size 1?

They're exported to debugfs and the relevant debugfs helpers take bool
as an argument (actually I've got a feeling the relevant API is changed
in -next which is likely to be an issue here...).

Attachment: signature.asc
Description: Digital signature