Re: [PATCH v3 7/7] ARM: bcm2835: Add VC4 to the device tree.

[Eric Anholt]

Stefan Wahren <info@xxxxxxxxxxxxxx> writes:

> Am 09.10.2015 um 23:27 schrieb Eric Anholt:
>> VC4 is the GPU (display and 3D) present on the 2835.
>>
>> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx>
>> ---
>>
>> v2: Sort by register address, mark HDMI as disabled by default in the
>>      SoC file and enable it from -rpi.
>>
>> v3: Add references to the pixel/HSM clocks for HDMI.  Rename
>>      compatibility strings and clean up node names.
>>
>>   arch/arm/boot/dts/bcm2835-rpi.dtsi |  4 ++++
>>   arch/arm/boot/dts/bcm2835.dtsi     | 42 ++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 46 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
>> index 3572f03..dcaaee2 100644
>> --- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
>> @@ -56,6 +56,10 @@
>>   	status = "okay";
>>   };
>>
>> +&hdmi {
>> +	status = "okay";
>> +};
>> +
>>   &sdhci {
>>   	status = "okay";
>>   	bus-width = <4>;
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> index 1e61eb7..21e354a9 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -1,4 +1,5 @@
>>   #include <dt-bindings/pinctrl/bcm2835.h>
>> +#include <dt-bindings/gpio/gpio.h>
>>   #include <dt-bindings/clock/bcm2835.h>
>>   #include "skeleton.dtsi"
>>
>> @@ -149,6 +150,18 @@
>>   			status = "disabled";
>>   		};
>>
>> +		pixelvalve@7e206000 {
>> +			compatible = "brcm,bcm2835-pixelvalve0";
>> +			reg = <0x7e206000 0x100>;
>> +			interrupts = <2 13>; /* pwa2 */
>
> According to BCM2835-ARM-Peripherals this should be pwa0.
>
> Is it just a typo?
> What does pwa mean?

Just a typo.  I don't know what pwa means, either, it's just a string so
you can search for it in the docs.

Attachment: signature.asc
Description: PGP signature