Re: [PATCH] staging: wilc1000: remove WILC1000_DYNAMICALLY_ALLOCATE_MEMROY

[Greg KH]

On Sat, Oct 10, 2015 at 03:41:54PM +0300, Stanislav Kholmanskikh wrote:
> The config option in the subject may be removed, because,
> indeed, it only serves as the 'n' value for
> CONFIG_WILC1000_PREALLOCATE_AT_LOADING_DRIVER
> 
> Signed-off-by: Stanislav Kholmanskikh <kholmanskikh.s.s@xxxxxxxxx>
> ---
>  drivers/staging/wilc1000/Kconfig  | 15 ++-------------
>  drivers/staging/wilc1000/Makefile |  3 ---
>  2 files changed, 2 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig
> index 59ccecc..2701a01 100644
> --- a/drivers/staging/wilc1000/Kconfig
> +++ b/drivers/staging/wilc1000/Kconfig
> @@ -6,27 +6,16 @@ config WILC1000
>  	---help---
>  	  This module only support IEEE 802.11n WiFi.
>  
> -choice
> -        prompt "Memory Allocation"
> -        depends on WILC1000
> -        default WILC1000_PREALLOCATE_AT_LOADING_DRIVER
> -
>  config WILC1000_PREALLOCATE_AT_LOADING_DRIVER
>  	bool "Preallocate memory at loading driver"
> +	depends on WILC1000
> +	default y

Hm, why have this now?  Both of these options should go away, please
work on fixing up the code to not need them and then delete the options,
right now you are just deleting config options which doesn't seem wise.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/