Re: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

From: Lee Jones
Date: Tue Oct 13 2015 - 03:32:07 EST


On Thu, 08 Oct 2015, Steve Twiss wrote:

> From: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
>
> Definitions for GPIO registers 8, 9, 10, 11, 12 and 13 are added into
> the register header file.
>
> - DA9052_GPIO_8_9_REG 25
> - DA9052_GPIO_10_11_REG 26
> - DA9052_GPIO_12_13_REG 27
>
> A modification is also made to the MFD core code to define these registers
> as readable and writable. The functions for da9052_reg_readable() and
> da9052_reg_writeable() have had their case statements altered to include
> these new registers.
>
> Signed-off-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx>
>
> ---
> This patch applies against linux-next and v4.3-rc4
>
>
> drivers/mfd/da9052-core.c | 6 ++++++
> include/linux/mfd/da9052/reg.h | 3 +++
> 2 files changed, 9 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/da9052-core.c b/drivers/mfd/da9052-core.c
> index 46e3840..c0bf68a 100644
> --- a/drivers/mfd/da9052-core.c
> +++ b/drivers/mfd/da9052-core.c
> @@ -51,6 +51,9 @@ static bool da9052_reg_readable(struct device *dev, unsigned int reg)
> case DA9052_GPIO_2_3_REG:
> case DA9052_GPIO_4_5_REG:
> case DA9052_GPIO_6_7_REG:
> + case DA9052_GPIO_8_9_REG:
> + case DA9052_GPIO_10_11_REG:
> + case DA9052_GPIO_12_13_REG:
> case DA9052_GPIO_14_15_REG:
> case DA9052_ID_0_1_REG:
> case DA9052_ID_2_3_REG:
> @@ -178,6 +181,9 @@ static bool da9052_reg_writeable(struct device *dev, unsigned int reg)
> case DA9052_GPIO_2_3_REG:
> case DA9052_GPIO_4_5_REG:
> case DA9052_GPIO_6_7_REG:
> + case DA9052_GPIO_8_9_REG:
> + case DA9052_GPIO_10_11_REG:
> + case DA9052_GPIO_12_13_REG:
> case DA9052_GPIO_14_15_REG:
> case DA9052_ID_0_1_REG:
> case DA9052_ID_2_3_REG:
> diff --git a/include/linux/mfd/da9052/reg.h b/include/linux/mfd/da9052/reg.h
> index c4dd3a8..5010f97 100644
> --- a/include/linux/mfd/da9052/reg.h
> +++ b/include/linux/mfd/da9052/reg.h
> @@ -65,6 +65,9 @@
> #define DA9052_GPIO_2_3_REG 22
> #define DA9052_GPIO_4_5_REG 23
> #define DA9052_GPIO_6_7_REG 24
> +#define DA9052_GPIO_8_9_REG 25
> +#define DA9052_GPIO_10_11_REG 26
> +#define DA9052_GPIO_12_13_REG 27
> #define DA9052_GPIO_14_15_REG 28
>
> /* POWER SEQUENCER CONTROL REGISTERS */

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/