Re: [PATCH 3/4] ARM: multi_v7_defconfig: Enable Maxim 8997 family drivers

[Javier Martinez Canillas]

Hello Krzysztof,

On Tue, Oct 13, 2015 at 3:27 AM, Krzysztof Kozlowski
<k.kozlowski@xxxxxxxxxxx> wrote:
> Enable support for Maxim 8997 Multi Function Device present on Trats and
> Origen boards by toggling on drivers: main MFD, charger, haptic motor,
> regulator, LED and RTC.
>
> This allows to test and usage of these boards with multi_v7 config.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---

[snip]

>  CONFIG_MFD_MAX77686=y
>  CONFIG_MFD_MAX77693=y
>  CONFIG_MFD_MAX8907=y
> +CONFIG_MFD_MAX8997=y

Only slightly related with your patch but some of the MFD driver for
PMICs used in Exynos boards (like MAX77686) have a tristate Kconfig
symbol while others like this one have a boolean. Do you know if there
are any restrictions w.r.t build this as module or is just an
arbitrary decision? I'm asking since probably we should either allow
this to build as a module or convert the others to boolean.

Patch looks good to me:

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/