[PATCH v2 06/17] irqdomain: Introduce irq_create_fwspec_mapping

From: Marc Zyngier
Date: Tue Oct 13 2015 - 07:56:39 EST


Just like we have irq_create_of_mapping, irq_create_fwspec_mapping
creates a IRQ domain mapping for an interrupt described in a
struct irq_fwspec.

irq_create_of_mapping gets rewritten in terms of the new function,
and the hack we introduced before gets removed (now that no stacked
irqchip uses of_phandle_args anymore).

Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
---
include/linux/irqdomain.h | 1 +
kernel/irq/irqdomain.c | 30 +++++++++++++++---------------
2 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
index 533c974..7e7842e 100644
--- a/include/linux/irqdomain.h
+++ b/include/linux/irqdomain.h
@@ -267,6 +267,7 @@ extern void irq_domain_disassociate(struct irq_domain *domain,

extern unsigned int irq_create_mapping(struct irq_domain *host,
irq_hw_number_t hwirq);
+extern unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec);
extern void irq_dispose_mapping(unsigned int virq);

/**
diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 86dfd40..b1fda6d 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -514,37 +514,28 @@ static void of_phandle_args_to_fwspec(struct of_phandle_args *irq_data,
fwspec->param[i] = irq_data->args[i];
}

-unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
+unsigned int irq_create_fwspec_mapping(struct irq_fwspec *fwspec)
{
- struct irq_fwspec fwspec;
struct irq_domain *domain;
irq_hw_number_t hwirq;
unsigned int type = IRQ_TYPE_NONE;
int virq;

- of_phandle_args_to_fwspec(irq_data, &fwspec);
-
- if (fwspec.fwnode)
- domain = irq_find_matching_fwnode(fwspec.fwnode, DOMAIN_BUS_ANY);
+ if (fwspec->fwnode)
+ domain = irq_find_matching_fwnode(fwspec->fwnode, DOMAIN_BUS_ANY);
else
domain = irq_default_domain;

if (!domain) {
pr_warn("no irq domain found for %s !\n",
- of_node_full_name(to_of_node(fwspec.fwnode)));
+ of_node_full_name(to_of_node(fwspec->fwnode)));
return 0;
}

- if (irq_domain_translate(domain, &fwspec, &hwirq, &type))
+ if (irq_domain_translate(domain, fwspec, &hwirq, &type))
return 0;

if (irq_domain_is_hierarchy(domain)) {
- /* Temporary hack */
- void *desc = &fwspec;
-#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
- if (!domain->ops->translate)
- desc = irq_data;
-#endif
/*
* If we've already configured this interrupt,
* don't do it again, or hell will break loose.
@@ -553,7 +544,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
if (virq)
return virq;

- virq = irq_domain_alloc_irqs(domain, 1, NUMA_NO_NODE, desc);
+ virq = irq_domain_alloc_irqs(domain, 1, NUMA_NO_NODE, fwspec);
if (virq <= 0)
return 0;
} else {
@@ -569,6 +560,15 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
irq_set_irq_type(virq, type);
return virq;
}
+EXPORT_SYMBOL_GPL(irq_create_fwspec_mapping);
+
+unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data)
+{
+ struct irq_fwspec fwspec;
+
+ of_phandle_args_to_fwspec(irq_data, &fwspec);
+ return irq_create_fwspec_mapping(&fwspec);
+}
EXPORT_SYMBOL_GPL(irq_create_of_mapping);

/**
--
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/