Re: [PATCH] ARM: socfpga: dts: add fpga manager

[Steffen Trumtrar]

Hi!

On Tue, Oct 13, 2015 at 09:46:15PM +0200, atull wrote:
> On Tue, 13 Oct 2015, Dinh Nguyen wrote:
> 
> > On Tue, 13 Oct 2015, Steffen Trumtrar wrote:
> > 
> > > Hi Alan!
> > > 
> > > On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@xxxxxxxxxxxxxxxxxxxxx wrote:
> > > > From: Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
> > > > 
> > > > Add FPGA manager to device tree for SoCFPGA.
> > > > 
> > > > Signed-off-by: Alan Tull <atull@xxxxxxxxxxxxxxxxxxxxx>
> > > > ---
> > > >  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > > index 314e589..e37ba11 100644
> > > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > > @@ -834,5 +834,12 @@
> > > >  			compatible = "altr,sys-mgr", "syscon";
> > > >  			reg = <0xffd08000 0x4000>;
> > > >  		};
> > > > +
> > > > +		hps_0_fpgamgr: fpgamgr@0xff706000 {
> > > > +			compatible = "altr,socfpga-fpga-mgr";
> > > > +			reg = <0xFF706000 0x1000
> > > > +			       0xFFB90000 0x1000>;
> > > > +			interrupts = <0 175 4>;
> > > > +		};
> > > >  	};
> > > >  };
> > > 
> > > Please keep the format in line with the rest of the file:
> > > Hexvalues are lowercase and no 0x after the "fpgamgr@".
> > > I'd say "And please put the node in its proper position
> > > according to its address", but I see just now, that the
> > > dtsi is all messed up right now anyway :-(
> > > 
> 
> "all messed up" seems kind of unclear and overstated here.  From the 
> context, I assume you mean that you are pointing out that the nodes
> are in more or less alphatetical order and not in order of address.  Is 
> that what you mean or is the dtsi really all messed up?
> 

"more or less" was the thing that bugged me.
And for the record: I didn't try to blame anyone for this. I put
many of the nodes there myself ;-)

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/