Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message

From: Mark Brown
Date: Wed Oct 14 2015 - 06:57:14 EST


On Fri, Oct 09, 2015 at 09:24:51AM -0500, Michael Welling wrote:
> On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote:
> > On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote:
> > > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote:

> > > What is the point of doing this void cast below?
> > > Avoiding compiler warning perhaps?
> > > Perhaps you can __maybe_unused for the variable instead?

> > > > + /* Ignore message */
> > > > + (void)msg;

> > You shouldn't need it at all, but yes if there is a good reason to mark
> > something as unused the above annotation is better.

> Which one?

__maybe_unused.

Attachment: signature.asc
Description: PGP signature