Re: drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67
From: Julia Lawall
Date: Wed Oct 14 2015 - 08:30:47 EST
Please check whether not releasing the lock is intentional.
julia
On Wed, 14 Oct 2015, kbuild test robot wrote:
> CC: kbuild-all@xxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx
> TO: Ben Skeggs <bskeggs@xxxxxxxxxx>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 5b5f1455272e23f4e7889cec37228802d8d01adf
> commit: 344c2d429dd86b1b0113177e18f15adb74e9d936 drm/nouveau/fb: remove dependence on namedb/engctx lookup
> date: 7 weeks ago
> :::::: branch date: 16 hours ago
> :::::: commit date: 7 weeks ago
>
> >> drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67
>
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git remote update linus
> git checkout 344c2d429dd86b1b0113177e18f15adb74e9d936
> vim +70 drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c
>
> 344c2d42 Ben Skeggs 2015-08-20 61 }
> 344c2d42 Ben Skeggs 2015-08-20 62
> 344c2d42 Ben Skeggs 2015-08-20 63 struct nvkm_fifo_chan *
> 344c2d42 Ben Skeggs 2015-08-20 64 nvkm_fifo_chan_chid(struct nvkm_fifo *fifo, int chid, unsigned long *rflags)
> 344c2d42 Ben Skeggs 2015-08-20 65 {
> 344c2d42 Ben Skeggs 2015-08-20 66 unsigned long flags;
> 344c2d42 Ben Skeggs 2015-08-20 @67 spin_lock_irqsave(&fifo->lock, flags);
> 344c2d42 Ben Skeggs 2015-08-20 68 if (fifo->channel[chid]) {
> 344c2d42 Ben Skeggs 2015-08-20 69 *rflags = flags;
> 344c2d42 Ben Skeggs 2015-08-20 @70 return (void *)fifo->channel[chid];
> 344c2d42 Ben Skeggs 2015-08-20 71 }
> 344c2d42 Ben Skeggs 2015-08-20 72 spin_unlock_irqrestore(&fifo->lock, flags);
> 344c2d42 Ben Skeggs 2015-08-20 73 return NULL;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/