Re: [PATCH v5 0/4] PCI: Add support for PCI Enhanced Allocation "BARs"

[David Daney]

On 10/14/2015 09:17 AM, Sean O. Stalley wrote:
> Signed-off-by: Sean O. Stalley <sean.stalley@xxxxxxxxx>

Thanks a lot Sean.

I think you cannot SOB if the patches are not flowing through you (as 
may be the case for my two additions).  Perhaps a Tested-by: or 
Acked-by: would be more appropriate.

> I tested it out with the QEMU EA Patches here:
> 	[https://lists.nongnu.org/archive/html/qemu-devel/2015-07/msg00348.html]
>
> Also, I found 1 trivial typo in the commit message of PATCH 1/4:
> 	"Signed-off-by: Signed-off-by: David Daney <david.daney@xxxxxxxxxx>"

Aargh!  I need to be more careful.

In any case, what should be the next course of action?

  A) I receive Tested-by/Acked-by from Sean, and resend the four patches?

  B) Bjorn takes these as is, but fixes the headers as needed.

Bjorn, what do you think?

Thanks,
David Daney


> -Sean
>
> On Wed, Oct 07, 2015 at 06:44:52AM -0700, Stalley, Sean wrote:
> > [PATCH 3/4 & 4/4] Acked-by: Sean O. Stalley <sean.stalley@xxxxxxxxx>
> >
> > I won't be able to test it out until next week, but I like how it looks :)
> >
> > Thanks Again,
> > Sean
> >
> > > -----Original Message-----
> > > From: David Daney [mailto:ddaney.cavm@xxxxxxxxx]
> > > Sent: Tuesday, October 06, 2015 4:51 PM
> > > To: linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Bjorn Helgaas;
> > > Michael S. Tsirkin; RafaÅ MiÅecki; linux-api@xxxxxxxxxxxxxxx; Stalley, Sean;
> > > yinghai@xxxxxxxxxx; rajatxjain@xxxxxxxxx; gong.chen@xxxxxxxxxxxxxxx
> > > Cc: David Daney
> > > Subject: [PATCH v5 0/4] PCI: Add support for PCI Enhanced Allocation
> > > "BARs"
> > >
> > > From: David Daney <david.daney@xxxxxxxxxx>
> > >
> > > The original patches are from Sean O. Stalley. I made a few tweaks, but feel
> > > that it is substancially Sean's work, so I am keeping the patch set version
> > > numbering scheme going.
> > >
> > > Tested on Cavium ThunderX system with 4 Root Complexes containing 50
> > > devices/bridges provisioned with EA.
> > >
> > > Here is Sean's description of the patches:
> > >
> > > PCI Enhanced Allocation is a new method of allocating MMIO & IO
> > > resources for PCI devices & bridges. It can be used instead of the traditional
> > > PCI method of using BARs.
> > >
> > > EA entries are hardware-initialized to a fixed address.
> > > Unlike BARs, regions described by EA are cannot be moved.
> > > Because of this, only devices which are permanently connected to the PCI
> > > bus can use EA. A removable PCI card must not use EA.
> > >
> > > This patchset adds support for using EA entries instead of BARs on Root
> > > Complex Integrated Endpoints.
> > >
> > > The Enhanced Allocation ECN is publicly available here:
> > > https://www.pcisig.com/specifications/conventional/ECN_Enhanced_Alloca
> > > tion_23_Oct_2014_Final.pdf
> > >
> > >
> > > Changes from V1:
> > > 	- Use generic PCI resource claim functions (instead of EA-specific
> > > functions)
> > > 	- Only add support for RCiEPs (instead of all devices).
> > > 	- Removed some debugging messages leftover from early testing.
> > >
> > > Changes from V2 (By David Daney):
> > > 	- Add ea_cap to struct pci_device, to aid in finding the EA capability.
> > > 	- Factored EA entity decoding into a separate function.
> > > 	- Add functions to find EA entities by BEI or Property.
> > > 	- Add handling of EA provisioned bridges.
> > > 	- Add handling of EA SRIOV BARs.
> > > 	- Try to assign proper resource parent so that SRIOV device creation
> > > can occur.
> > >
> > > Changes from V3 (By David Daney):
> > > 	- Discarded V3 changes and started over fresh based on Sean's V2.
> > > 	- Add more support/checking for Entry Properties.
> > > 	- Allow EA behind bridges.
> > > 	- Rewrite some error messages.
> > > 	- Add patch 3/5 to prevent resizing, and better handle
> > >            assigning, of fixed EA resources.
> > > 	- Add patch 4/5 to handle EA provisioned SRIOV devices.
> > > 	- Add patch 5/5 to handle EA provisioned bridges.
> > >
> > > Changes from V4 (By David Daney):
> > > 	- Drop patch 5/5 to handle EA provisioned bridges.
> > > 	- Drop cases for bridge resources in 2/5.
> > > 	- Drop unnecessary fallback resource parent handling in 3/5
> > > 	- Small code formatting improvements.
> > >
> > > David Daney (2):
> > >    PCI: Handle IORESOURCE_PCI_FIXED when sizing and assigning resources.
> > >    PCI: Handle Enhanced Allocation (EA) capability for SRIOV devices.
> > >
> > > Sean O. Stalley (2):
> > >    PCI: Add Enhanced Allocation register entries
> > >    PCI: Add support for Enhanced Allocation devices
> > >
> > >   drivers/pci/iov.c             |  11 ++-
> > >   drivers/pci/pci.c             | 189
> > > ++++++++++++++++++++++++++++++++++++++++++
> > >   drivers/pci/pci.h             |   1 +
> > >   drivers/pci/probe.c           |   3 +
> > >   drivers/pci/setup-bus.c       |  50 ++++++++++-
> > >   include/uapi/linux/pci_regs.h |  44 +++++++++-
> > >   6 files changed, 292 insertions(+), 6 deletions(-)
> > >
> > > --
> > > 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/