Re: [PATCH v6 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1

[Jianqun Xu]

å 2015å10æ15æ 16:53, Lars-Peter Clausen åé:
> On 10/15/2015 03:36 AM, Shawn Lin wrote:
> [...]
> > +
> > +	if (snd_dmaengine_pcm_get_caps(&pdev->dev, &dma_caps) == 0) {
> > +		if (dma_caps.max_burst > 4) {
> > +			i2s->playback_dma_data.maxburst = 4;
> > +			i2s->capture_dma_data.maxburst = 4;
> > +		} else {
> > +			i2s->playback_dma_data.maxburst = 1;
> > +			i2s->capture_dma_data.maxburst = 1;
> So this is what this is all about? I though you might have to program some
> FIFO threshold registers in the peripheral itself.
>
> But it seems all this does is to read the maximum burst length from the DMA
> controller only to tell the DMA controller that this is the maximum burst
> length it should use. That seems rather unnecessary.
>
> The maxburst field of the dma_data indicates the maximum burst length that
> the audio peripheral can handle. Typically this is the number of samples the
> audio FIFO can receive without overflowing after sending the DMA request
> signal. Since as the name suggests this is the maximum burst size the DMA
> controller is free to choose a burst size smaller than this when writing
> data to the peripheral.
>
> So in your case instead of introducing all these facilities to query the
> maximum burst size it should be OK to simply reduce the burst size in the
> DMA controller itself when it gets a request with a burst size larger than
> it can handle, or is there a reason why this is not possible?
Agree with Lars, it's better to fix on DMA driver side since issue 
caused by dma-controller instead of i2s controller
> - Lars

--
Jianqun Xu | Software engineer | 18750760928


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/