Re: [PATCH] HID: roccat: Deprecating most Roccat sysfs attributes

From: Greg KH
Date: Thu Oct 15 2015 - 14:49:52 EST


On Thu, Oct 15, 2015 at 05:00:09PM +0200, Stefan Achatz wrote:
> Deprecates all Roccat sysfs attributes except the ones for the old Kone by moving
> abi descriptions from testing to obsolete.
> For most devices everything can be done using the hidraw ioctls HIDIOCGFEATURE
> and HIDIOCSFEATURE, so I would suggest future removal of device specific drivers.
> The userspace tools don't use these attributes for a year now.
> The first Kone is not fully HID-compliant and will still need a module.
>
> Signed-off-by: Stefan Achatz <erazor_de@xxxxxxxxxxxxxxxxxxxxx>
> ---
> .../ABI/obsolete/sysfs-driver-hid-roccat-arvo | 53 ++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-isku | 153 ++++++++++++++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-koneplus | 99 +++++++++++-
> .../ABI/obsolete/sysfs-driver-hid-roccat-konepure | 105 ++++++++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-kovaplus | 50 ++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-lua | 7 +
> .../ABI/obsolete/sysfs-driver-hid-roccat-pyra | 50 ++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-ryos | 178 +++++++++++++++++++++
> .../ABI/obsolete/sysfs-driver-hid-roccat-savu | 76 +++++++++
> .../ABI/testing/sysfs-driver-hid-roccat-arvo | 53 ------
> .../ABI/testing/sysfs-driver-hid-roccat-isku | 153 ------------------
> .../ABI/testing/sysfs-driver-hid-roccat-koneplus | 96 -----------
> .../ABI/testing/sysfs-driver-hid-roccat-konepure | 105 ------------
> .../ABI/testing/sysfs-driver-hid-roccat-kovaplus | 49 ------
> .../ABI/testing/sysfs-driver-hid-roccat-lua | 7 -
> .../ABI/testing/sysfs-driver-hid-roccat-pyra | 49 ------
> .../ABI/testing/sysfs-driver-hid-roccat-ryos | 178 ---------------------
> .../ABI/testing/sysfs-driver-hid-roccat-savu | 76 ---------
> 18 files changed, 770 insertions(+), 767 deletions(-)
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-arvo
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-isku
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-konepure
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-lua
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-ryos
> create mode 100644 Documentation/ABI/obsolete/sysfs-driver-hid-roccat-savu
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-arvo
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-isku
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-koneplus
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-konepure
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-kovaplus
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-lua
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-pyra
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-ryos
> delete mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-savu

If you make your patch with 'git format-patch -M' we can see the files
being moved much easier than deleting and adding the files.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/