Re: [PATCH v2] powerpc/mpc5xxx: Avoid dereferencing potentially freed memory

[Christophe JAILLET]

Le 15/10/2015 08:36, Michael Ellerman a Ãcrit :
> On Thu, 2015-10-15 at 07:56 +0200, Christophe JAILLET wrote:
> > Use 'of_property_read_u32()' instead of 'of_get_property()'+pointer
> > dereference in order to avoid access to potentially freed memory.
> >
> > Use 'of_get_next_parent()' to simplify the while() loop and avoid the
> > need of a temp variable.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > ---
> > v2: Use of_property_read_u32 instead of of_get_property+pointer dereference
> > *** Untested ***
> Thanks.
>
> Can someone with an mpc5xxx test this?
>
> cheers

Hi,
I don't think it is an issue, but while looking at another similar 
patch, I noticed that the proposed patch adds a call to be32_to_cpup() 
(within of_property_read_u32).
Apparently, powerPC is a BE architecture, so this call should be a no-op.

Just wanted to point it out, in case of.

Best regards,
CJ

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/