[PATCH] h8300: Don't set CROSS_COMPILE unconditionally

[Javier Martinez Canillas]

The h8300 architecture Makefile sets the CROSS_COMPILE variable to
"h8300-unknown-linux-" unconditionally but doing that prevents the
variable to be used if a toolchain with a different binary name is
installed in the machine.

So only set CROSS_COMPILE to that default if the variable has not
been set by the user before.

Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

---

Hello,

After $SUBJECT, I'm able to build using the toolchain installed by
my Linux distribution but the linker gives me an error about an
unrecognised emulation mode:

h8300-linux-gnu-ld: unrecognised emulation mode: h8300helf_linux

I see that h8300helf_linux and 8300self_linux are hardcoded in the
Makefile as well and these are not listed as supported emulations:

Supported emulations: h8300elf h8300helf h8300self h8300hnelf h8300snelf h8300sxelf h8300sxnelf

I tried changing -mh8300helf_linux for -mh8300helf that is listed
as a supported emulation but then I got the following error:

h8300-linux-gnu-ld: cannot open linker script file ldscripts/h8300helf.xr: No such file or directory

Best regards,
Javier

 arch/h8300/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/h8300/Makefile b/arch/h8300/Makefile
index 0d2d96e52d9f..e1c02ca230cb 100644
--- a/arch/h8300/Makefile
+++ b/arch/h8300/Makefile
@@ -22,7 +22,9 @@ KBUILD_CFLAGS += -DUTS_SYSNAME=\"uClinux\"
 KBUILD_AFLAGS += $(aflags-y)
 LDFLAGS += $(ldflags-y)
 
+ifeq ($(CROSS_COMPILE),)
 CROSS_COMPILE := h8300-unknown-linux-
+endif
 
 core-y	+= arch/$(ARCH)/kernel/ arch/$(ARCH)/mm/
 ifneq '$(CONFIG_H8300_BUILTIN_DTB)' '""'
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/