Re: [PATCH] clk: Allow drivers to build if COMPILE_TEST is enabled

From: Javier Martinez Canillas
Date: Fri Oct 16 2015 - 08:18:37 EST


Hello Stephen,

On 10/14/2015 11:13 PM, Stephen Boyd wrote:
> On 10/14, Javier Martinez Canillas wrote:
>> On 10/14/2015 09:08 PM, Javier Martinez Canillas wrote:
>>> Hello Stephen,
>>>
>>> On 10/14/2015 08:38 PM, Stephen Boyd wrote:
>>>> On 10/13, Javier Martinez Canillas wrote:
>>>>> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig
>>>>> index 1530c9352a76..fc50b6264bed 100644
>>>>> --- a/drivers/clk/versatile/Kconfig
>>>>> +++ b/drivers/clk/versatile/Kconfig
>>>>> @@ -1,6 +1,6 @@
>>>>> config COMMON_CLK_VERSATILE
>>>>> bool "Clock driver for ARM Reference designs"
>>>>> - depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64
>>>>> + depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || COMPILE_TEST
>>>>
>>>> Have you compiled these drivers on an architecture that doesn't
>>>> have IOMEM? Perhaps tile or um? I'm all for more build coverage,
>>>> but it's not always as simple as just sprinkling some
>>>> COMPILE_TEST around the Kconfigs.
>>>>
>>>
>>> No, I only build tested on arm32 and x86. The 0-day bot haven't reported a
>>> build error yet and I didn't see any platform dependent code in the drivers.
>>>
>>
>> BTW, all clk drivers depends on COMMON_CLK so these won't even be built in
>> tile or um since that symbol isn't selected there. Or did I misunderstand?
>>
>> Having said that, I see that enabling COMPILE_TEST will attempt to build
>> in many archs [0] that I don't have a toolchain to test. So I'm OK if you
>> drop this patch and sorry for the inconvenience.
>>
>> [0]:
>> $ git grep "select COMMON_CLK" arch/ | cut -d '/' -f2 | uniq
>> arc
>> arm
>> arm64
>> h8300
>> microblaze
>> mips
>> powerpc
>> x86
>> xtensa
>>
>
> Ah that's good. So assuming someone has built these patches with
> these architectures then we've got it all covered. Do you know if
> kbuild does that? There are a bunch of cross compilers on
> kernel.org that may help[1]. I'll wait to apply the patch once we
> get that confirmation.
>
> [1] https://www.kernel.org/pub/tools/crosstool/
>

I built on all those archs and neither allyesconfig nor allmodconfig
gives me build error or warnings for the partial build M=drivers/clk

I only had an issue with h8300 since the arch has hardcoded stuff
in its Makefile like the toolchain file name, I posted a patch [0]
to fix that but then got a linker issue. This not related to $SUBJECT
though but to the h8300 arch Makefile.

[0]: https://lkml.org/lkml/2015/10/16/342

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/