Re: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties
From: Philipp Zabel
Date: Fri Oct 16 2015 - 09:09:12 EST
Hi CK,
there is a typo in the subject: s/Dcumentation/Documentation/.
Am Freitag, den 16.10.2015, 20:15 +0800 schrieb CK Hu:
> From: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
>
> Add documentation for DT properties supported by ps8640
> DSI-eDP converter.
>
> Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
[...]
> + - ps8640-1v2-supply: OF device-tree regulator specification for 1v2.
> + - ps8640-3v3-supply: OF device-tree regulator specification for 3v3.
The ps8640- part of the regulator supply property names is redundant.
The PS8622 driver uses vdd12-supply as its regulator. Should we strive
for consistency here? Or if you have access to the datasheet, how are
these inputs called there?
> +
> +Optional properties:
> + - video interfaces: Device node can contain video interface port
> + nodes for panel according to [1].
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
It should be documented here that port@0 is the input port and port@1 is
the output port.
best regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/