Q: schedule() and implied barriers on arm64
From: Peter Zijlstra
Date: Fri Oct 16 2015 - 11:18:38 EST
Hi,
IIRC Paul relies on schedule() implying a full memory barrier with
strong transitivity for RCU.
If not, ignore this email.
If so, however, I suspect AARGH64 is borken and would need (just like
PPC):
#define smp_mb__before_spinlock() smp_mb()
The problem is that schedule() (when a NO-OP) does:
smp_mb__before_spinlock();
LOCK rq->lock
clear_bit()
UNLOCK rq->lock
And nothing there implies a full barrier on AARGH64, since
smp_mb__before_spinlock() defaults to WMB, LOCK is an "ldaxr" or
load-acquire, UNLOCK is "stlrh" or store-release and clear_bit() isn't
anything.
Pretty much every other arch has LOCK implying a full barrier, either
because its strongly ordered or because it needs one for the ACQUIRE
semantics.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/