Re: [PATCH v3 3/3] misc: Add w2sg0004 gps receiver driver

[Arnd Bergmann]

On Friday 16 October 2015 21:27:11 H. Nikolaus Schaller wrote:
> Am 16.10.2015 um 21:06 schrieb Arnd Bergmann <arnd@xxxxxxxx>:
> 
> > On Friday 16 October 2015 20:08:35 H. Nikolaus Schaller wrote:
> >> +
> >> +static int w2sg_data_probe(struct platform_device *pdev)
> >> +{
> >> +       struct w2sg_pdata *pdata = dev_get_platdata(&pdev->dev);
> >> +       struct w2sg_data *data;
> >> +       struct rfkill *rf_kill;
> >> +       int err;
> >> +
> >> +       pr_debug("%s()\n", __func__);
> >> +
> >> +       if (pdev->dev.of_node) {
> >> +               struct device *dev = &pdev->dev;
> >> +               enum of_gpio_flags flags;
> >> +
> >> +               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> >> +               if (!pdata)
> >> 
> > 
> > Why is this a platform_device and not a serio_device?
> 
> I can't find a struct serio_device. What is that?
> 

Sorry, I meant 'struct serio', see drivers/input/serio/

This is an existing infrastructure that is used for devices attached
to a dumb serial device (rs232 or 8042/psaux usually). They have
a user interface for connecting a driver to a port, but you should
be able to do it all in the kernel as well if DT has the information
what device is connected.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/