Re: [PATCH] mm/maccess.c: actually return -EFAULT from strncpy_from_unsafe

[Alexei Starovoitov]

On 10/17/15 1:20 PM, Rasmus Villemoes wrote:
> As far as I can tell, strncpy_from_unsafe never returns -EFAULT. ret
> is the result of a __copy_from_user_inatomic(), which is 0 for success
> and positive (in this case necessarily 1) for access error - it is
> never negative. So we were always returning the length of the,
> possibly truncated, destination string.
>
> Signed-off-by: Rasmus Villemoes<linux@xxxxxxxxxxxxxxxxxx>
> ---
> Probably not -stable-worthy. I can only find two callers, one of which
> ignores the return value.

good catch.
Acked-by: Alexei Starovoitov <ast@xxxxxxxxxx>

cc-ing original authors where I copy pasted that part from.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/