Re: [PATCH V3] debugfs: Add debugfs_create_ulong()

From: Greg Kroah-Hartman
Date: Sun Oct 18 2015 - 13:10:24 EST


On Sun, Oct 18, 2015 at 10:14:09PM +0530, Viresh Kumar wrote:
> On 18-10-15, 09:21, Greg Kroah-Hartman wrote:
> > On Sun, Oct 18, 2015 at 02:45:27PM +0530, Viresh Kumar wrote:
> > > Add debugfs_create_ulong() for the users of type 'unsigned long'. These
> > > will be 32 bits long on a 32 bit machine and 64 bits long on a 64 bit
> > > machine.
> >
> > Do you really need a debugfs_create_xlong()? You don't mention it here
> > in your changelog comment yet the patch contains it. I'd hold off for
> > it for now as I doubt anyone needs it...
>
> At least my use case doesn't need it, but I thought it will be better
> to implement the ulong series in the same way other interfaces are
> implemented.
>
> I can drop that part if you want.

Please do, I don't like adding apis that no one uses.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/