Re: [PATCH] net, can, ti_hecc: fix a run time warn_on.

From: Heiko Schocher
Date: Mon Oct 19 2015 - 02:51:08 EST


Hello Marc,

Am 19.10.2015 um 08:34 schrieb Marc Kleine-Budde:
On 10/19/2015 08:22 AM, Heiko Schocher wrote:
This patch fixes a warning in clk_enable by calling
clk_prepare_enable instead.

What about the corresponding clk_disable_unprepare()?

Yes, that should be fixed too, do this in a v2, thanks!

bye,
Heiko

Marc


Signed-off-by: Heiko Schocher <hs@xxxxxxx>
---

drivers/net/can/ti_hecc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index cf345cb..c08e8ea 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -951,7 +951,7 @@ static int ti_hecc_probe(struct platform_device *pdev)
netif_napi_add(ndev, &priv->napi, ti_hecc_rx_poll,
HECC_DEF_NAPI_WEIGHT);

- clk_enable(priv->clk);
+ clk_prepare_enable(priv->clk);
err = register_candev(ndev);
if (err) {
dev_err(&pdev->dev, "register_candev() failed\n");




--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/