Re: [PATCH 1/1] perf/x86: Fix time_shift in perf_event_mmap_page

From: Ingo Molnar
Date: Mon Oct 19 2015 - 04:09:04 EST



* Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:

> Commit b20112edeadf ("perf/x86: Improve accuracy of perf/sched clock")
> allowed the time_shift value in perf_event_mmap_page to be as much
> as 32. Unfortunately the documented algorithms for using time_shift
> have it shifting an integer, whereas to work correctly with the value
> 32, the type must be u64.
>
> Fix by limiting the shift to 31 and adjusting the multiplier accordingly.
>
> Also update the documentation of perf_event_mmap_page so that new code
> based on it will be more future-proof.
>
> Fixes: b20112edeadf ("perf/x86: Improve accuracy of perf/sched clock")
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

Would be nice to point out via what symptoms the code misbehaves and how users
notice.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/