RE: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings

[Kwok, WingMan]

Roger,

> -----Original Message-----
> From: Quadros, Roger
> Sent: Friday, October 16, 2015 3:56 AM
> To: Kwok, WingMan; robh+dt@xxxxxxxxxx; pawel.moll@xxxxxxx;
> mark.rutland@xxxxxxx; ijc+devicetree@xxxxxxxxxxxxxx; galak@xxxxxxxxxxxxxx;
> KISHON VIJAY ABRAHAM; Karicheri, Muralidharan; bhelgaas@xxxxxxxxxx;
> ssantosh@xxxxxxxxxx; linux@xxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH] ARM: keystone: dts: add PCI serdes driver bindings
> 
> WingMan,
> 
> On 15/10/15 17:27, WingMan Kwok wrote:
> > This patch adds the required PCI serdes bindings whcih can then be
> > enabled by setting the corresponding statuses to "ok" in order to
> > configure and start the PCI serdes.
> >
> > This patch depends on the updates to the Keystone PCIe host driver
> > and common serdes driver patch series that is submitted separately.
> >
> > Signed-off-by: WingMan Kwok <w-kwok2@xxxxxx>
> > ---
> >  arch/arm/boot/dts/k2e.dtsi      |   21 +++++++++++++++++++++
> >  arch/arm/boot/dts/keystone.dtsi |   21 +++++++++++++++++++++
> >  2 files changed, 42 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/k2e.dtsi b/arch/arm/boot/dts/k2e.dtsi
> > index 675fb8e..3b36575 100644
> > --- a/arch/arm/boot/dts/k2e.dtsi
> > +++ b/arch/arm/boot/dts/k2e.dtsi
> > @@ -86,6 +86,16 @@
> >  			gpio,syscon-dev = <&devctrl 0x240>;
> >  		};
> >
> > +		pcie1_phy: pciephy@2326000 {
> 
> Should be
> 		pcie1_phy: phy@2326000 {
> 

will change in next version.

> > +			#phy-cells = <0>;
> > +			compatible = "ti,keystone-serdes-pcie";
> > +			reg = <0x02326000 0x4000>;
> > +			reg-names = "serdes";
> > +			link-rate-kbps = <5000000>;
> > +			num-lanes = <2>;
> > +			status = "disabled";
> > +		};
> > +
> >  		pcie1: pcie@21020000 {
> >  			compatible = "ti,keystone-pcie","snps,dw-pcie";
> >  			clocks = <&clkpcie1>;
> > @@ -130,6 +140,17 @@
> >  					<GIC_SPI 375 IRQ_TYPE_EDGE_RISING>,
> >  					<GIC_SPI 376 IRQ_TYPE_EDGE_RISING>;
> >  			};
> > +
> > +			/* PCIE phy */
> > +			serdeses {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				serdes@0 {
> > +					reg = <0>;
> > +					phys = <&pcie1_phy>;
> > +				};
> > +			};
> > +
> >  		};
> >
> >  		mdio: mdio@24200f00 {
> > diff --git a/arch/arm/boot/dts/keystone.dtsi
> b/arch/arm/boot/dts/keystone.dtsi
> > index 72816d6..6566cc4 100644
> > --- a/arch/arm/boot/dts/keystone.dtsi
> > +++ b/arch/arm/boot/dts/keystone.dtsi
> > @@ -275,6 +275,16 @@
> >  			ti,syscon-dev = <&devctrl 0x2a0>;
> >  		};
> >
> > +		pcie0_phy: pciephy@2320000 {
> 
> ditto.
> 

will change in next version.

> > +			#phy-cells = <0>;
> > +			compatible = "ti,keystone-serdes-pcie";
> > +			reg = <0x02320000 0x4000>;
> > +			reg-names = "serdes";
> > +			link-rate-kbps = <5000000>;
> > +			num-lanes = <2>;
> > +			status = "disabled";
> > +		};
> > +
> >  		pcie0: pcie@21800000 {
> >  			compatible = "ti,keystone-pcie", "snps,dw-pcie";
> >  			clocks = <&clkpcie>;
> > @@ -319,6 +329,17 @@
> >  					<GIC_SPI 28 IRQ_TYPE_EDGE_RISING>,
> >  					<GIC_SPI 29 IRQ_TYPE_EDGE_RISING>;
> >  			};
> > +
> > +			/* PCIE phy */
> > +			serdeses {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				serdes@0 {
> > +					reg = <0>;
> > +					phys = <&pcie0_phy>;
> > +				};
> > +			};
> > +
> >  		};
> >  	};
> >  };
> >
> 
> --
> cheers,
> -roger

Thanks,
WingMan