Re: [RFC v3 3/9] kmsg: introduce additional kmsg devices support

[kbuild test robot]

Hi Marcin,

[auto build test WARNING on next-20151016 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Paul-Osmialowski/Additional-kmsg-devices/20151019-211509
config: i386-defconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/fs.h:5:0,
                    from kernel/printk/kmsg.c:5:
   kernel/printk/kmsg.c: In function 'kmsg_sys_write':
   include/linux/wait.h:171:47: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
    #define wake_up_interruptible(x) __wake_up(x, TASK_INTERRUPTIBLE, 1, NULL)
                                                  ^
>> kernel/printk/kmsg.c:49:3: note: in expansion of macro 'wake_up_interruptible'
      wake_up_interruptible(&log_b->wait);
      ^
   include/linux/wait.h:171:47: note: each undeclared identifier is reported only once for each function it appears in
    #define wake_up_interruptible(x) __wake_up(x, TASK_INTERRUPTIBLE, 1, NULL)
                                                  ^
>> kernel/printk/kmsg.c:49:3: note: in expansion of macro 'wake_up_interruptible'
      wake_up_interruptible(&log_b->wait);
      ^
   kernel/printk/kmsg.c: In function 'kmsg_read':
   include/linux/wait.h:400:31: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
     ___wait_event(wq, condition, TASK_INTERRUPTIBLE, 0, 0,  \
                                  ^
   include/linux/wait.h:225:52: note: in definition of macro '___wait_event'
      long __int = prepare_to_wait_event(&wq, &__wait, state);\
                                                       ^
   include/linux/wait.h:423:11: note: in expansion of macro '__wait_event_interruptible'
      __ret = __wait_event_interruptible(wq, condition); \
              ^
   kernel/printk/kmsg.c:140:9: note: in expansion of macro 'wait_event_interruptible'
      ret = wait_event_interruptible(log_b->wait,
            ^
   include/linux/wait.h:198:43: error: 'TASK_KILLABLE' undeclared (first use in this function)
      state == TASK_INTERRUPTIBLE || state == TASK_KILLABLE) \
                                              ^
   include/linux/wait.h:230:7: note: in expansion of macro '___wait_is_interruptible'
      if (___wait_is_interruptible(state) && __int) {  \
          ^
   include/linux/wait.h:400:2: note: in expansion of macro '___wait_event'
     ___wait_event(wq, condition, TASK_INTERRUPTIBLE, 0, 0,  \
     ^
   include/linux/wait.h:423:11: note: in expansion of macro '__wait_event_interruptible'
      __ret = __wait_event_interruptible(wq, condition); \
              ^
   kernel/printk/kmsg.c:140:9: note: in expansion of macro 'wait_event_interruptible'
      ret = wait_event_interruptible(log_b->wait,
            ^
   include/linux/wait.h:401:9: error: implicit declaration of function 'schedule' [-Werror=implicit-function-declaration]
            schedule())
            ^
   include/linux/wait.h:240:3: note: in definition of macro '___wait_event'
      cmd;       \
      ^
   include/linux/wait.h:423:11: note: in expansion of macro '__wait_event_interruptible'
      __ret = __wait_event_interruptible(wq, condition); \
              ^
   kernel/printk/kmsg.c:140:9: note: in expansion of macro 'wait_event_interruptible'
      ret = wait_event_interruptible(log_b->wait,
            ^
   cc1: some warnings being treated as errors

vim +/wake_up_interruptible +49 kernel/printk/kmsg.c

     1	#include <linux/printk.h>
     2	#include <linux/kernel.h>
     3	#include <linux/errno.h>
     4	#include <linux/fcntl.h>
   > 5	#include <linux/fs.h>
     6	#include <linux/kmsg_dump.h>
     7	#include <linux/moduleparam.h>
     8	#include <linux/mutex.h>
     9	#include <linux/spinlock.h>
    10	#include <linux/slab.h>
    11	#include <linux/poll.h>
    12	#include <linux/rculist.h>
    13	#include <linux/rcupdate.h>
    14	#include <linux/stat.h>
    15	#include <linux/syslog.h>
    16	#include <linux/uio.h>
    17	#include <linux/wait.h>
    18	
    19	#include <asm/uaccess.h>
    20	
    21	#include "printk.h"
    22	
    23	/* /dev/kmsg - userspace message inject/listen interface */
    24	struct devkmsg_user {
    25		u64 seq;
    26		u32 idx;
    27		enum log_flags prev;
    28		struct mutex lock;
    29		char buf[CONSOLE_EXT_LOG_MAX];
    30	};
    31	
    32	static int kmsg_sys_write(int minor, int level, const char *fmt, ...)
    33	{
    34		va_list args;
    35		int ret = -ENXIO;
    36		struct log_buffer *log_b;
    37	
    38		rcu_read_lock();
    39		list_for_each_entry_rcu(log_b, &log_buf.list, list) {
    40			if (log_b->minor != minor)
    41				continue;
    42	
    43			raw_spin_lock(&log_b->lock);
    44	
    45			va_start(args, fmt);
    46			log_format_and_store(log_b, 1 /* LOG_USER */, level,
    47					     NULL, 0, fmt, args);
    48			va_end(args);
  > 49			wake_up_interruptible(&log_b->wait);
    50	
    51			raw_spin_unlock(&log_b->lock);
    52	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data