RE: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and pcie
From: Kwok, WingMan
Date: Mon Oct 19 2015 - 10:48:52 EST
Hi,
> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@xxxxxxxx]
> Sent: Thursday, October 15, 2015 3:35 PM
> To: Karicheri, Muralidharan
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Kwok, WingMan; robh+dt@xxxxxxxxxx;
> pawel.moll@xxxxxxx; mark.rutland@xxxxxxx; ijc+devicetree@xxxxxxxxxxxxxx;
> galak@xxxxxxxxxxxxxx; KISHON VIJAY ABRAHAM; Quadros, Roger;
> bhelgaas@xxxxxxxxxx; ssantosh@xxxxxxxxxx; linux@xxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> pci@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 1/2] phy: keystone: serdes driver for gbe 10gbe and
> pcie
>
> On Thursday 15 October 2015 12:01:04 Murali Karicheri wrote:
> >
> > >> + * Redistributions in binary form must reproduce the above copyright
> > >> + * notice, this list of conditions and the following disclaimer in the
> > >> + * documentation and/or other materials provided with the
> > >> + * distribution.
> > >
> > > The current code does not do this when compiled, which might be a
> > > problem for distributors. Can you clarify the license?
> > >
> > Arnd,
> >
> > Can you elaborate on this? I did a grep on the string "Redistributions
> > in binary form must reproduce the above copyright" and I could find
> > several instance of this. So I am not sure what you mean by "The current
> > code does not do this when compiled".
>
> You write that the binary form of the code must produce the copyright
> notice. I don't see any code that does this. If I was looking in the
> wrong place, let me know.
>
> Arnd
For example, we did a grep of the following
mypc:linux(personal/linux/serdes) $ grep -rnI "Redistributions in binary form must reproduce the above copyright" ./net/
./net/sunrpc/auth_gss/auth_gss.c:18: * 2. Redistributions in binary form must reproduce the above copyright
./net/sunrpc/auth_gss/gss_mech_switch.c:15: * 2. Redistributions in binary form must reproduce the above copyright
./net/sunrpc/auth_gss/gss_krb5_mech.c:16: * 2. Redistributions in binary form must reproduce the above copyright
./net/bluetooth/ecc.c:10: * * Redistributions in binary form must reproduce the above copyright
./net/bluetooth/ecc.h:10: * * Redistributions in binary form must reproduce the above copyright
./net/can/gw.c:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/can/af_can.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/can/proc.c:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/can/bcm.c:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/can/raw.c:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/can/af_can.h:10: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/discover.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/node.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/netlink_compat.c:10: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/name_distr.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/bearer.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/name_table.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/name_distr.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/addr.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/subscr.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/link.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/net.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/netlink.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/sysctl.c:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/udp_media.c:11: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/socket.h:11: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/subscr.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/msg.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/name_table.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/msg.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/core.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/socket.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/net.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/bcast.c:14: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/bearer.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/core.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/node.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/addr.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/ib_media.c:17: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/link.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/netlink.h:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/server.c:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/discover.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/eth_media.c:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/bcast.h:13: * 2. Redistributions in binary form must reproduce the above copyright
./net/tipc/server.h:12: * 2. Redistributions in binary form must reproduce the above copyright
./net/6lowpan/iphc.c:29: * 2. Redistributions in binary form must reproduce the above copyright
./net/sched/sch_codel.c:17: * 2. Redistributions in binary form must reproduce the above copyright
./net/ieee802154/6lowpan/core.c:27: * 2. Redistributions in binary form must reproduce the above copyright
Thanks,
WingMan