Re: [PATCH 21/31] perf test: Enforce LLVM test, add kbuild test

[Wangnan (F)]

On 2015/10/19 22:53, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 19, 2015 at 11:42:31PM +0900, Namhyung Kim escreveu:
> > Hi,
> >
> > On Wed, Oct 14, 2015 at 12:41:32PM +0000, Wang Nan wrote:
> > > This patch enforces existing LLVM test, makes it compile more than one
> > > BPF source file. The compiled results are stored, can be used for other
> > > testcases. Except the first testcase (named LLVM_TESTCASE_BASE), failures
> > > of other test cases are not considered as failure of the whole test.
> > >
> > > Adds a kbuild testcase to check whether kernel headers can be correctly
> > > found.
> > >
> > > For example:
> > >
> > >   # perf test LLVM
> > >
> > >     38: Test LLVM searching and compiling                        : (llvm.kbuild-dir can be fixed) Ok
> > IMHO it'd be better to keep the test result simply as either "Ok" or
> > "FAILED" and provide details with -v option.

I have to say I'm not the first one to output things like this:

 #perf test dummy attr
 14: struct perf_event_attr setup                             : 
(omitted) Ok
 23: Test using a dummy software event to keep tracking       : (not 
supported) Ok

Do you think they also need to be fixed?

> "Skipped" looks more natural here, with the reason for it skipping being shown
> only with -v.

For this specific case, I will change the logic:

 1. When basic test failed (no clang, compiling error...), report failure;

 2. When basic test passed but kbuild test or later test cases failed, 
report
    Skip.

 3. Don't output any other information.

Thank you.

> Ingo made some comments about 'perf test' output recently, have you read that?
>
> > Anyway I found the tracepoint error message is annoying in the current
> You mean all these warnings:
>
> [root@zoo ~]# perf test "parse event"
>   5: parse events tests                                       :  Warning: [sunrpc:xprt_lookup_rqst] function __builtin_constant_p not defined
>    Warning: [sunrpc:xprt_transmit] function __builtin_constant_p not defined
>    Warning: [sunrpc:xprt_complete_rqst] function __builtin_constant_p not defined
> <SNIP>
>    Warning: [xen:xen_mmu_set_pud] function sizeof not defined
>    Warning: [xen:xen_mmu_set_pgd] function sizeof not defined
>    Warning: [xen:xen_mmu_ptep_modify_prot_start] function sizeof not defined
>    Warning: [xen:xen_mmu_ptep_modify_prot_commit] function sizeof not defined
>   Ok
> [root@zoo ~]#
>
> i.e. making those warnings appear only under 'perf test -v'? Cool!
>
> > perf test output.  Will send a fix soon.
> >
> > Thanks,
> > Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/