Re: [RFC v4 9/9] kmsg: selftests

[Paul Osmialowski]

Hi Shuah,

Thanks for your comments,

On Mon, 19 Oct 2015, Shuah Khan wrote:

> > --- a/tools/testing/selftests/Makefile
> > +++ b/tools/testing/selftests/Makefile
> > @@ -7,6 +7,7 @@ TARGETS += ftrace
> >  TARGETS += futex
> >  TARGETS += kcmp
> >  TARGETS += kdbus
>
> Doesn't look like this patch is based on linux-kselftest next
> or Linus's latest. Please base your work on either one of the
> above. Please make sure "make kselftest" from top level Makefile
> doesn't break.
>
> > +TARGETS += kmsg

Any guidelines what such test should be implemented (apart from use of 
kselftest.h API)?

> > +kmsg-test: $(OBJS)
> > +	$(CC) $(CFLAGS) $^ $(LDLIBS) -o $@
> > +
> > +run_tests:
> > +	./kmsg-test --tap
>
> What does --tap do? Is this a longform option?
> I don't see it in usage()

Should be removed - I copy-pasted parts of kdbus selftests Makefile not 
noticing that.

Best regards,
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/