Re: [PATCH 0/5] Fix regression introduced by set_irq_flags() removal
From: Thomas Petazzoni
Date: Tue Oct 20 2015 - 10:08:36 EST
Jason,
On Tue, 20 Oct 2015 14:04:27 +0000, Jason Cooper wrote:
> Whole series,
>
> Reviewed by: Jason Cooper <jason@xxxxxxxxxxxxxx>
Thanks.
> Thomas (tglx), if you're happy with the core changes, let me know and
> I'll cue the series up.
>
> We know it's a bit late in the -rc cycle, but the alternative (reverting
> Rob's patch) would likely be more destabilizing at this point.
As discussed on IRC, another simpler (code line wise) solution is to
simply clear the IRQ_NOAUTOEN flag in the irq-armada-370-xp, which
brings us back to what set_irq_flags() was doing, without actually
reverting Rob's patch.
However, relying on IRQ_NOAUTOEN being cleared doesn't seem like the
right long term solution, which is why I implemented what I believe is
a (hopefully) better long term solution.
But if you/tglx want something simple/stupid for 4.3 (one-line patch)
and then the real stuff for 4.4, I'd be happy to provide a series
implementing this idea.
Let me know what you and tglx think.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/