Re: [PATCH] x86, perf: Use INST_RETIRED.PREC_DIST for cycles:pp on Skylake

From: Andi Kleen
Date: Tue Oct 20 2015 - 18:28:55 EST


> Typically on workstations you do not, because there's only a single
> user, but on servers it might be more common. The thing I expect to be
> most common is having both a CPU wide and a per task cycle counter
> enabled.

With multiple users they would sample only their own processes.
That works fine. The only thing that needs multiplexing is overlapping
sampling.

perf top also works fine because it doesn't use PEBS by default.

> And you having killed the flag bits for PEBS events precludes people
> from using this manually, right? I think we want to exempt .inv=1
> .cmask=16 from that general rule on general utility value.

I don't want to do this for every event. It has caused problems
in the past. There's also no reason to use the other events.

> We could maybe abuse .precise_ip = 3 for this?

I implemented this now, even though it's ugly.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/