Re: [PATCH 10/19] ARM: dts: at91: replace gpio-key,wakeup with wakeup-source property

[Sudeep Holla]

On 21/10/15 12:01, Ulf Hansson wrote:
> On 21 October 2015 at 12:25, Sudeep Holla <sudeep.holla@xxxxxxx> wrote:
> > On 21/10/15 11:21, Nicolas Ferre wrote:
> > > Le 21/10/2015 12:10, Sudeep Holla a Ãcrit :
> > > > Though the keyboard driver for GPIO buttons(gpio-keys) will continue to
> > > > check for/support the legacy "gpio-key,wakeup" boolean property to
> > > > enable gpio buttons as wakeup source, "wakeup-source" is the new
> > > > standard binding.
> > > >
> > > > This patch replaces the legacy "gpio-key,wakeup" with the unified
> > > > "wakeup-source" property in order to avoid any futher copy-paste
> > > > duplication.
> > > >
> > > > Cc: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> > >
> > >
> > > I'm not against this if the whole series goes further.
> > > Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
> >
> > Thanks !
> >
> > > I suspect that we would need to take this patch with us on the AT91
> > > branches that would go to arm-soc. Is it the intentions?
> >
> > Yes that was my intention for splitting the patches per SoC group.
> > Many SoC maintainers prefer that.
>
> Hold on! All patches that changes the DT parsing to accept the
> "standardized wakeup-source" binding, need to be merged upstream
> before corresponding DTS changes.

Agreed. Sorry for that I forgot about it as there are only few
subsystems that needed additions. Most of the input subsystem had
already moved to new binding, just that binding documents were left
unchanged.

> Therefore, I suggest we go for a two step approach, starting with
> changes affecting the DT parsing/documentation for various
> drivers/subsystem and perhaps we can reach 4.4 for these.
> Then the DTS changes can go in at any later point.

Looks good to me.

--
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/