Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read

From: Peter Korsgaard
Date: Wed Oct 21 2015 - 10:23:29 EST


>>>>> "Bartosz" == Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> writes:

>> As the serial number is available on a separate i2c address, wouldn't
>> it be simpler to handle these as special (read only) device variants and
>> instantiate E.G. a 24c64 (for the normal data) and a 24cs64 (for the
>> serial)?
>>

> Hi Peter,

> I wanted to respond that this way we would not be protected from
> concurrent accesses, but then I saw I didn't actually include any
> locks in the serial read function - my bad. It needs to be fixed as
> both memory blocks share the same address pointer.

> I'll resend the series.

But we're protected by the i2c bus lock, right? You do a single
i2c_transfer to read the serial number.

--
Venlig hilsen,
Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/