Re: [PATCH -next] net: hisilicon: Never build on SPARC
From: David Miller
Date: Wed Oct 21 2015 - 11:11:32 EST
From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Wed, 21 Oct 2015 07:29:33 -0700
> The Hisilicon network driver does not build for Sparc. Enabling
> COMPILE_TEST for it causes Sparc allmodconfig/allyesconfig builds
> to fail with
>
> drivers/net/ethernet/hisilicon/hns_mdio.c: In function 'hns_mdio_bus_name':
> drivers/net/ethernet/hisilicon/hns_mdio.c:409:3: error:
> implicit declaration of function 'of_translate_address'
>
> Fixes: 876133d3161d ("net: hisilicon: add OF dependency")
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
I wish we would really resolve this properly instead of hacking crap
like this all the time, it's stupid.
SPARC simply never needs to "translate" OF addresses, since all OF
resources are fully translated already at boot time during OF tree
import.
All IRQs are fully resolved as well.
So we could simply make of_translate_address() a NOP.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/