Re: [PATCH v6 1/4] of: overlay: kobjectify overlay objects

[Greg Kroah-Hartman]

On Wed, Oct 21, 2015 at 04:28:33PM +0300, Pantelis Antoniou wrote:
> Hi Greg,
> 
> > On Oct 21, 2015, at 00:03 , Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > On Tue, Oct 20, 2015 at 10:13:14PM +0300, Pantelis Antoniou wrote:
> >> We are going to need the overlays to appear on sysfs with runtime
> >> global properties (like master enable) so turn them into kobjects.
> > 
> > Why kobjects and not 'struct deviceâ?
> > 
> 
> Cause itâs overkill.
> 
> There is no hardware/abstract device connection between an overlay and a device as whatâs being used right now in driver core.
> 
> kobjs are enough to present them in the filesystem hierarchy.
> 
> > Why even have them in sysfs at all?  You need more information here as
> > to why you want to do this.
> > 
> 
> They have to be in sysfs so that people can have information about the overlays applied in the system, i.e. where their targets are and whether removal is possible. Thatâs whatâs possible for now; in the future we might present the full contents of the overlay there, and what changes to the live tree were made.

Ok, then say that in the changelog to explain what you are doing here :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/