Re: [PATCH 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

From: kbuild test robot
Date: Wed Oct 21 2015 - 11:47:25 EST


Hi Punit,

[auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url: https://github.com/0day-ci/linux/commits/Punit-Vara/Fix-warnings-reported-by-coccicheck/20151021-230937
config: x86_64-allyesconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/net/wireless//ti/wlcore/acx.c: In function 'wl1271_acx_mem_map':
>> drivers/net/wireless//ti/wlcore/acx.c:161:6: warning: unused variable 'ret' [-Wunused-variable]
int ret;
^

vim +/ret +161 drivers/net/wireless//ti/wlcore/acx.c

f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 145
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 146 ret = wl1271_cmd_configure(wl, ACX_FEATURE_CFG,
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 147 feature, sizeof(*feature));
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 148 if (ret < 0) {
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 149 wl1271_error("Couldnt set HW encryption");
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 150 goto out;
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 151 }
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 152
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 153 out:
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 154 kfree(feature);
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 155 return ret;
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 156 }
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 157
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 158 int wl1271_acx_mem_map(struct wl1271 *wl, struct acx_header *mem_map,
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 159 size_t len)
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 160 {
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 @161 int ret;
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 162
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 163 wl1271_debug(DEBUG_ACX, "acx mem map");
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 164
1686f7fd1 drivers/net/wireless/ti/wlcore/acx.c Punit Vara 2015-10-21 165 return wl1271_cmd_interrogate(wl, ACX_MEM_MAP, mem_map,
4b6741443 drivers/net/wireless/ti/wlcore/acx.c Igal Chernobelsky 2013-09-09 166 sizeof(struct acx_header), len);
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 167 }
f5fc0f86b drivers/net/wireless/wl12xx/wl1271_acx.c Luciano Coelho 2009-08-06 168
8793f9bb1 drivers/net/wireless/wl12xx/wl1271_acx.c Juuso Oikarinen 2009-10-13 169 int wl1271_acx_rx_msdu_life_time(struct wl1271 *wl)

:::::: The code at line 161 was first introduced by commit
:::::: f5fc0f86b02afef1119b523623b4cde41475bc8c wl1271: add wl1271 driver files

:::::: TO: Luciano Coelho <luciano.coelho@xxxxxxxxx>
:::::: CC: John W. Linville <linville@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data