Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

From: Namhyung Kim
Date: Thu Oct 22 2015 - 03:39:10 EST


Hi Ingo,

On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>
>> The caller callchain order is useful with --children option since it can
>> show 'overview' style output, but other commands which don't use
>> --children feature like 'perf script' or even 'perf report/top' without
>> --children are better to keep caller order.

Oops, there's a typo: s/caller order/callee order/ :)


>>
>> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
>> Cc: Borislav Petkov <bp@xxxxxxx>
>> Cc: Brendan Gregg <brendan.d.gregg@xxxxxxxxx>
>> Cc: Chandler Carruth <chandlerc@xxxxxxxxx>
>> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
>> Cc: Stephane Eranian <eranian@xxxxxxxxxx>
>> Cc: Wang Nan <wangnan0@xxxxxxxxxx>
>> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
>
> Very nice fixes, thanks!

Thank you!
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/