Re: [PATCH 26/31] perf tools: Support perf event alias name

[Wangnan (F)]

On 2015/10/22 15:53, Namhyung Kim wrote:
> On Thu, Oct 22, 2015 at 4:29 PM, Wangnan (F) <wangnan0@xxxxxxxxxx> wrote:
> >

[SNIP]
> > > I understand the need of using aliases but I think it's more natural
> > > to use event name for simple cases..
> >
> > I will consider this. However, if we allow using event name directly like
> > this:
> >
> >   # perf record -e cycles -e test_pmu.c/myevent=cycles/ ...
> >
> > Then two '-e' seems redundant, right? Why not directly using:
> >
> >   # perf record -e test_pmu.c/myevent=cycles/ ...
> >
> > and make perf creates cycles event for test_pmu.c?
> >
> > We can make syntax like
> >
> >   # perf record -e test_pmu.c/myevent=cycles/ ...
> >
> > as a syntax sugar of
> >
> >   # perf record -e randomname=cycles -e test_pmu.c/myevent=randomname/ ...
> >
> > and don't need to find evsel through their names if alias not exist.
> >
> > So this is a new feature, and worth another patch.
> >
> > Thought?
> Not sure it's worth.  It can confuse users IMHO.
>
> Isn't it enough to give them in a single argument?
>
>    # perf record -e cycles,test_pmu.c/myevent=cycles/

OK. I have put it on my todo-list.

Thank you.
> Thanks,
> Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/