Re: [PATCH] tools lib traceevent: Support %ps/%pS
From: Arnaldo Carvalho de Melo
Date: Thu Oct 22 2015 - 14:26:56 EST
Em Thu, Oct 22, 2015 at 01:07:29PM -0400, Steven Rostedt escreveu:
>
> This fell through the abyss of my INBOX.
>
> Arnaldo, can you take this.
Sure
> Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> -- Steve
>
>
> On Mon, 31 Aug 2015 16:16:37 -0500
> Scott Wood <scottwood@xxxxxxxxxxxxx> wrote:
>
> > Commits such as 65dd297ac25565 ("xfs: %pF is only for function
> > pointers") caused a regression because pretty_print() didn't support
> > %ps/%pS. The current %pf/%pF implementation in pretty_print() is what
> > %ps/%pS is supposed to do, so use the same code for %ps/%pS.
> >
> > Addressing the incorrect %pf/%pF implementation is beyond the scope of
> > this patch.
> >
> > Signed-off-by: Scott Wood <scottwood@xxxxxxxxxxxxx>
> > ---
> > tools/lib/traceevent/event-parse.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > index cc25f05..f05e5b0 100644
> > --- a/tools/lib/traceevent/event-parse.c
> > +++ b/tools/lib/traceevent/event-parse.c
> > @@ -4761,8 +4761,8 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
> > else
> > ls = 2;
> >
> > - if (*(ptr+1) == 'F' ||
> > - *(ptr+1) == 'f') {
> > + if (*(ptr+1) == 'F' || *(ptr+1) == 'f' ||
> > + *(ptr+1) == 'S' || *(ptr+1) == 's') {
> > ptr++;
> > show_func = *ptr;
> > } else if (*(ptr+1) == 'M' || *(ptr+1) == 'm') {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/