Re: [PATCH v7 03/60] sparc/PCI: Unify pci_register_region()
From: Yinghai Lu
Date: Thu Oct 22 2015 - 15:56:21 EST
On Wed, Oct 21, 2015 at 6:15 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Wed, Oct 21, 2015 at 3:59 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> On Wed, Oct 21, 2015 at 3:32 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>>> On Wed, Oct 21, 2015 at 11:50 AM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>>>> Lots of other architectures have both mem32 and mem64 apertures. You
>>>> haven't explained what's unique about sparc yet. Does
>>>> pci_find_parent_resource() not work on sparc? If not, is that because the
>>>> resource tree looks different on sparc than on other architectures? If so,
>>>> is that difference something intentional that we want to keep, or should we
>>>> converge on a single resource tree format across all architectures?
>>>
>>> In the new pci_register_legacy_regions(), we only have root bus.
>>> but current pci_find_parent_resource is taking pci dev.
>>>
>>> So will need to change it to take bus instead, please check if you are ok
>>> with following, then I would update other two.
>>
>> Never mind, I could just one dummy pci device to work around it.
>> so don't need to change that.
>
> Khalid,
>
> Please use attached two to replace patch2, patch3 and patch4.
>
looks like i mix the use root bus resource with parent bus resource ...
so that still have problem.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/