Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function

From: Arnd Bergmann
Date: Fri Oct 23 2015 - 09:12:57 EST


On Friday 23 October 2015 14:37:14 Eric Auger wrote:
> Remove the static lookup table and use the dynamic list of registered
> reset functions instead. Also load the reset module through its alias.
> The reset struct module pointer is stored in vfio_platform_device.
>
> We also remove the useless struct device pointer parameter in
> vfio_platform_get_reset.
>
> This patch fixes the issue related to the usage of __symbol_get, which
> besides from being moot, prevented compilation with CONFIG_MODULES
> disabled.
>
> Also usage of MODULE_ALIAS makes possible to add a new reset module
> without needing to update the framework. This was suggested by Arnd.
>
> Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx>
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
>
>
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

but doesn't this need to come before patch 4/7?

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/