Re: [PATCH v5 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

[Bjorn Andersson]

On Thu, Oct 22, 2015 at 11:57 AM, Punit Vara <punitvara@xxxxxxxxx> wrote:

Hi Punit,

> Remove empty line suggested by Sergei
>

A commit message is here to, in the future, help us all understand
what and why this change was made, so you should not include comments
about what you changed since a previous version of this patch.

> This patch is to the ath5k/eeprom.c that fixes up warning caught by
> coccicheck:
>

You don't need to indicate what files are changed in the commit
message, as that information is already available in the body of the
commit. And the comment stats the wrong file.

> Unneeded variable: "ret". Return "0" on line 980
>
> Remove unneeded variable ret created to return zero.
>

Both of these are only reiterating what the subject already states -
in two different ways. So you can easily remove them without loosing
any information. In fact, the subject is all you need to describe the
change.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/