Re: [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix
From: Jonathan Cameron
Date: Sun Oct 25 2015 - 08:36:44 EST
On 14/10/15 16:27, Michael Welling wrote:
> On Wed, Oct 14, 2015 at 02:54:38PM +0200, Javier Martinez Canillas wrote:
>> The Microchip Analog to Digital Converter (ADC) Device Tree binding
>> documents compatible strings with no vendor prefix. Since it should
>> compatible strings with also a vendor, add these to the binding doc
>> and mark the old ones as deprecated.
>>
>> The driver says that the device is from Microchip Technology which
>> is listed in Documentation/devicetree/bindings/vendor-prefixes.txt
>> so use the documented prefix.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> ---
>>
>> .../devicetree/bindings/iio/adc/mcp320x.txt | 30 +++++++++++++++-------
>> 1 file changed, 21 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> index 2a1f3af30155..bcd3ac8e6e0c 100644
>> --- a/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> +++ b/Documentation/devicetree/bindings/iio/adc/mcp320x.txt
>> @@ -10,16 +10,28 @@ must be specified.
>> Required properties:
>> - compatible: Must be one of the following, depending on the
>> model:
>> - "mcp3001"
>> - "mcp3002"
>> - "mcp3004"
>> - "mcp3008"
>> - "mcp3201"
>> - "mcp3202"
>> - "mcp3204"
>> - "mcp3208"
>> - "mcp3301"
>> + "mcp3001" (DEPRECATED)
>> + "mcp3002" (DEPRECATED)
>> + "mcp3004" (DEPRECATED)
>> + "mcp3008" (DEPRECATED)
>> + "mcp3201" (DEPRECATED)
>> + "mcp3202" (DEPRECATED)
>> + "mcp3204" (DEPRECATED)
>> + "mcp3208" (DEPRECATED)
>> + "mcp3301" (DEPRECATED)
>>
>> + "microchip,mcp3001"
>> + "microchip,mcp3002"
>> + "microchip,mcp3004"
>> + "microchip,mcp3008"
>> + "microchip,mcp3201"
>> + "microchip,mcp3202"
>> + "microchip,mcp3204"
>> + "microchip,mcp3208"
>> + "microchip,mcp3301"
>> +
>> + NOTE: The use of the compatibles with no vendor prefix
>> + is deprecated and only listed because old DT use them.
>>
>
> Acked-by: Michael Welling <mwelling@xxxxxxxx>
Small point, Michael. Please add such acks below the the Author sign off.
Otherwise sometimes I miss them! Added it now for this one.
>
>> Examples:
>> spi_controller {
>> --
>> 2.4.3
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/