Re: [PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board

[Linus Walleij]

On Sat, Oct 17, 2015 at 7:23 PM, Maxime Coquelin
<mcoquelin.stm32@xxxxxxxxx> wrote:

> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
(...)
> +       leds {
> +               compatible = "gpio-leds";
> +               red {
> +                       gpios = <&gpiog 14 0>;
> +               };
> +               green {
> +                       gpios = <&gpiog 13 0>;
> +               };

I suggest you add labels to these LEDs.

label = "red-LED"
label = "green-LED"

This make things so much easier in sysfs.

Usually people also want to add a default linux,trigger to these,
like linux,default-trigger = "heartbeat"; but whatever you prefer.

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/