Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common

[Scott Wood]

On Tue, 2015-10-27 at 01:24 -0500, Zhao Qiang-B45475 wrote:
> On Tue, Oct 27, 2015 at 12:48 PM, Wood Scott-B07421 wrote:
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, October 27, 2015 12:48 PM
> > To: Zhao Qiang-B45475 <qiang.zhao@xxxxxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> > lauraa@xxxxxxxxxxxxxx; Xie Xiaobo-R63061 <X.Xie@xxxxxxxxxxxxx>;
> > benh@xxxxxxxxxxxxxxxxxxx; Li Yang-Leo-R58472 <LeoLi@xxxxxxxxxxxxx>;
> > paulus@xxxxxxxxx
> > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to
> > qe_common
> > 
> > On Sun, 2015-10-25 at 21:42 -0500, Zhao Qiang-B45475 wrote:
> > > On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote:
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Saturday, October 24, 2015 4:56 AM
> > > > To: Zhao Qiang-B45475 <qiang.zhao@xxxxxxxxxxxxx>
> > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> > > > lauraa@xxxxxxxxxxxxxx; Xie Xiaobo-R63061 <X.Xie@xxxxxxxxxxxxx>;
> > > > benh@xxxxxxxxxxxxxxxxxxx; Li Yang-Leo-R58472 <LeoLi@xxxxxxxxxxxxx>;
> > > > paulus@xxxxxxxxx
> > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management
> > functions
> > > > to qe_common
> > > > 
> > > > On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote:
> > > > > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421
> > > > > <scottwood@xxxxxxxxxxxxx>
> > > > > wrote:
> > > > > > -----Original Message-----
> > > > > > From: Wood Scott-B07421
> > > > > > Sent: Friday, October 23, 2015 11:10 AM
> > > > > > To: Zhao Qiang-B45475 <qiang.zhao@xxxxxxxxxxxxx>
> > > > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> > > > > > lauraa@xxxxxxxxxxxxxx; Xie Xiaobo-R63061 <X.Xie@xxxxxxxxxxxxx>;
> > > > > > benh@xxxxxxxxxxxxxxxxxxx; Li Yang-Leo-R58472
> > > > > > <LeoLi@xxxxxxxxxxxxx>; paulus@xxxxxxxxx
> > > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management
> > > > functions
> > > > > > to qe_common
> > > > > > 
> > > > > > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote:
> > > > > > > QE and CPM have the same muram, they use the same management
> > > > > > > functions. Now QE support both ARM and PowerPC, it is
> > > > > > > necessary to move QE to "driver/soc", so move the muram
> > > > > > > management functions from cpm_common to qe_common for
> > > > > > > preparing to move QE code to
> > > > "driver/soc"
> > > > > > > 
> > > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxxxxxxxx>
> > > > > > > ---
> > > > > > > Changes for v2:
> > > > > > >       - no changes
> > > > > > > Changes for v3:
> > > > > > >       - no changes
> > > > > > > Changes for v4:
> > > > > > >       - no changes
> > > > > > > Changes for v5:
> > > > > > >       - no changes
> > > > > > > Changes for v6:
> > > > > > >       - using genalloc instead rheap to manage QE MURAM
> > > > > > >       - remove qe_reset from platform file, using
> > > > > > >       - subsys_initcall to call qe_init function.
> > > > > > > Changes for v7:
> > > > > > >       - move this patch from 3/3 to 2/3
> > > > > > >       - convert cpm with genalloc
> > > > > > >       - check for gen_pool allocation failure Changes for v8:
> > > > > > >       - rebase
> > > > > > >       - move BD_SC_* macro instead of copy Changes for v9:
> > > > > > >       - doesn't modify CPM, add a new patch to modify.
> > > > > > >       - rebase
> > > > > > > Changes for v10:
> > > > > > >       - rebase
> > > > > > > Changes for v11:
> > > > > > >       - remove renaming
> > > > > > >       - delete removing qe_reset and delete adding qe_init.
> > > > > > > Changes for v12:
> > > > > > >       - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for
> > it.
> > > > > > 
> > > > > > Why is the SPI change part of this patch?  Why is it even part
> > > > > > of this patchset, rather than an independent patch sent to the
> > > > > > SPI list and maintainer?  If it's tied to other changes you're
> > > > > > making, explain that.  As is, there is zero mention of the SPI
> > > > > > change in the part of the e-mail that will become the git 
> > > > > > changelog.
> > > > > > 
> > > > > This SPI_FSL_CPM is cpm-spi, it is part of CPM.
> > > > 
> > > > So then why are you selecting QUICC_ENGINE?  And again, what does it
> > > > have to do with this patch?
> > > 
> > > Cpm-spi is dependent on qe_muram, if not select it, Cpm-spi will
> > > failed to build.
> > 
> > Why QUICC_ENGINE and not CPM?
> 
> QE and CPM use the same muram, and it has been moved to qe_muram from 
> cpm_muram.

Fix the makefiles so that the muram code continues to be built for both 
QUICC_ENGINE and CPM.  It's not acceptable to have to bring in the entire QE 
code just for the muram.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/