Re: [PATCH 2/3] megaraid_sas: Convert printk to printk_<level>

[Johannes Thumshirn]

On Tue, 2015-10-27 at 16:26 +0800, Weidong Wang wrote:
> Reduce object size a little by using pr_<level>
> calls instead of printk(KERN_<LEVEL>.
> 
> Signed-off-by: Weidong Wang <wangweidong1@xxxxxxxxxx>
> ---
> Âdrivers/scsi/megaraid/megaraid_sas_base.c | 14 +++++++-------
> Â1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index ed9846d..2287aa1 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5889,7 +5889,7 @@ static int megasas_mgmt_fasync(int fd, struct
> file *filep, int mode)
> Â		return 0;
> Â	}
> Â
> -	printk(KERN_DEBUG "megasas: fasync_helper failed [%d]\n",
> rc);
> +	pr_debug("megasas: fasync_helper failed [%d]\n", rc);
> Â
> Â	return rc;
> Â}
> @@ -6233,7 +6233,7 @@ static int megasas_mgmt_ioctl_aen(struct file
> *file, unsigned long arg)
> Â	u32 wait_time = MEGASAS_RESET_WAIT_TIME;
> Â
> Â	if (file->private_data != file) {
> -		printk(KERN_DEBUG "megasas: fasync_helper was not "
> +		pr_debug("megasas: fasync_helper was not "
> Â		ÂÂÂÂÂÂÂ"called first\n");
> Â		return -EINVAL;
> Â	}
> @@ -6355,7 +6355,7 @@ static int megasas_mgmt_compat_ioctl_fw(struct
> file *file, unsigned long arg)
> Â
> Â	if (copy_in_user(&cioc->frame.hdr.cmd_status,
> Â			Â&ioc->frame.hdr.cmd_status, sizeof(u8))) {
> -		printk(KERN_DEBUG "megasas: error copy_in_user
> cmd_status\n");
> +		pr_debug("megasas: error copy_in_user
> cmd_status\n");
> Â		return -EFAULT;
> Â	}
> Â	return error;
> @@ -6455,7 +6455,7 @@ megasas_sysfs_set_dbg_lvl(struct device_driver
> *dd, const char *buf, size_t coun
> Â	int retval = count;
> Â
> Â	if (sscanf(buf, "%u", &megasas_dbg_lvl) < 1) {
> -		printk(KERN_ERR "megasas: could not set dbg_lvl\n");
> +		pr_err("megasas: could not set dbg_lvl\n");
> Â		retval = -EINVAL;
> Â	}
> Â	return retval;
> @@ -6480,7 +6480,7 @@ megasas_aen_polling(struct work_struct *work)
> Â	int error;
> Â
> Â	if (!instance) {
> -		printk(KERN_ERR "invalid instance!\n");
> +		pr_err("invalid instance!\n");
> Â		kfree(ev);
> Â		return;
> Â	}
> @@ -6740,7 +6740,7 @@ static int __init megasas_init(void)
> Â	rval = register_chrdev(0, "megaraid_sas_ioctl",
> &megasas_mgmt_fops);
> Â
> Â	if (rval < 0) {
> -		printk(KERN_DEBUG "megasas: failed to open device
> node\n");
> +		pr_debug("megasas: failed to open device node\n");
> Â		return rval;
> Â	}
> Â
> @@ -6752,7 +6752,7 @@ static int __init megasas_init(void)
> Â	rval = pci_register_driver(&megasas_pci_driver);
> Â
> Â	if (rval) {
> -		printk(KERN_DEBUG "megasas: PCI hotplug registration
> failed \n");
> +		pr_debug("megasas: PCI hotplug registration failed
> \n");
> Â		goto err_pcidrv;
> Â	}
> Â


Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/