Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16
From: Simon Guinot
Date: Tue Oct 27 2015 - 10:39:49 EST
On Tue, Oct 27, 2015 at 04:23:43PM +0200, Mika Westerberg wrote:
> On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote:
> > > +menu "ISA GPIO drivers"
> > > +
> > > +config GPIO_104_IDIO_16
> > > + tristate "ACCES 104-IDIO-16 GPIO support"
> > > + depends on X86
> > > + help
> > > + Enables GPIO support for the ACCES 104-IDIO-16 family.
> > > +
> > > +endmenu
> >
> > I have five other drivers using port-based I/O:
> >
> > gpio-f7188x.c
> > gpio-it87.c
> > gpio-sch.c
> > gpio-sch311x.c
> > gpio-ts5500.c
> >
> > Do you think it makes sense to move all of these in under
> > the "ISA GPIO drivers" menu as well? I guess they all require
> > ISA after all.
> >
> > (Added their maintainers to the To: line so I can get some input
> > on this.)
>
> Not all of them actually require ISA. For example gpio-sch is part of an
> MFD device which is a PCI device. PCI bus also has notion of I/O ports.
Should this driver not be moved under the "MFD GPIO expanders" menu ?
Attachment:
signature.asc
Description: Digital signature